https://codereview.chromium.org/19540012/diff/1/src/log.cc
File src/log.cc (right):
https://codereview.chromium.org/19540012/diff/1/src/log.cc#newcode946
src/log.cc:946: class CodeEventLogger {
I'd rather extract EventDispatcher into a separate class and keep
CodeEventLoggger a part of Logger. The Logger would become one of the
event listener (like CpuProfiler, LowLevelLogger and others). In other
words I'd extract event dispatching out of Logger and leave only actual
logging functionality here. WDYT?
https://codereview.chromium.org/19540012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
