LGTM with nits.
https://codereview.chromium.org/19054006/diff/13001/src/effects.h
File src/effects.h (right):
https://codereview.chromium.org/19054006/diff/13001/src/effects.h#newcode122
src/effects.h:122: effect = Effect::Seq(locator.value(), effect,
Base::isolate());
nit: {} please
https://codereview.chromium.org/19054006/diff/13001/src/effects.h#newcode135
src/effects.h:135: effect = Effect::Alt(locator.value(), effect,
Base::isolate());
nit: {} please
https://codereview.chromium.org/19054006/diff/13001/src/effects.h#newcode216
src/effects.h:216: typedef ZoneSplayTree<SplayTreeConfig> Map;
We already have a v8::internal::Map. Please use another name here.
EffectsMap?
https://codereview.chromium.org/19054006/diff/13001/src/effects.h#newcode248
src/effects.h:248: explicit Effects(Zone* zone) :
nit: ':' goes on the next line. Line break suggestion:
explicit Effects(Zone* zone)
: EffectsMixin<Var,
EffectsBase<Var, kNoVar>,
Effects<Var, kNoVar> >(zone) {}
https://codereview.chromium.org/19054006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
