Reviewers: danno, Dmitry Lomov (chromium),
Description:
Unify SMI case inlining for ToNumberStub.
Use ShouldInlineSmiCase() on arm, mips and x64 similar to the ia32 port.
Please review this at https://codereview.chromium.org/19489003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-arm.cc
M src/mips/full-codegen-mips.cc
M src/x64/full-codegen-x64.cc
Index: src/arm/full-codegen-arm.cc
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc
index
1760fb8cf16c5c3b6e34c1be2b91202defea731c..6a5845de43f419d8c662948048e706b7adedb2eb
100644
--- a/src/arm/full-codegen-arm.cc
+++ b/src/arm/full-codegen-arm.cc
@@ -4436,7 +4436,9 @@ void
FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
// Call ToNumber only if operand is not a smi.
Label no_conversion;
- __ JumpIfSmi(r0, &no_conversion);
+ if (ShouldInlineSmiCase(expr->op())) {
+ __ JumpIfSmi(r0, &no_conversion);
+ }
ToNumberStub convert_stub;
__ CallStub(&convert_stub);
__ bind(&no_conversion);
Index: src/mips/full-codegen-mips.cc
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
index
51b71a671cf0b30fe07160dccfab40f55dd623ae..9c610c32f9db33f2edef307247f196d0ca76fc04
100644
--- a/src/mips/full-codegen-mips.cc
+++ b/src/mips/full-codegen-mips.cc
@@ -4470,7 +4470,9 @@ void
FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
// Call ToNumber only if operand is not a smi.
Label no_conversion;
- __ JumpIfSmi(v0, &no_conversion);
+ if (ShouldInlineSmiCase(expr->op())) {
+ __ JumpIfSmi(v0, &no_conversion);
+ }
__ mov(a0, v0);
ToNumberStub convert_stub;
__ CallStub(&convert_stub);
Index: src/x64/full-codegen-x64.cc
diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc
index
121ab2d1a0d9b4b70e70c0fbf3a5dfa36bf1c009..bac4e793b279bf4a86353db7024aa92352219e79
100644
--- a/src/x64/full-codegen-x64.cc
+++ b/src/x64/full-codegen-x64.cc
@@ -4420,7 +4420,9 @@ void
FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
// Call ToNumber only if operand is not a smi.
Label no_conversion;
- __ JumpIfSmi(rax, &no_conversion, Label::kNear);
+ if (ShouldInlineSmiCase(expr->op())) {
+ __ JumpIfSmi(rax, &no_conversion, Label::kNear);
+ }
ToNumberStub convert_stub;
__ CallStub(&convert_stub);
__ bind(&no_conversion);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
