Revision: 15787
Author: [email protected]
Date: Sun Jul 21 22:50:10 2013
Log: Unify SMI case inlining for ToNumberStub.
Use ShouldInlineSmiCase() on arm, mips and x64 similar to the ia32 port.
[email protected]
Review URL: https://codereview.chromium.org/19489003
http://code.google.com/p/v8/source/detail?r=15787
Modified:
/branches/bleeding_edge/src/arm/full-codegen-arm.cc
/branches/bleeding_edge/src/mips/full-codegen-mips.cc
/branches/bleeding_edge/src/x64/full-codegen-x64.cc
=======================================
--- /branches/bleeding_edge/src/arm/full-codegen-arm.cc Fri Jul 19 04:52:42
2013
+++ /branches/bleeding_edge/src/arm/full-codegen-arm.cc Sun Jul 21 22:50:10
2013
@@ -4436,7 +4436,9 @@
// Call ToNumber only if operand is not a smi.
Label no_conversion;
- __ JumpIfSmi(r0, &no_conversion);
+ if (ShouldInlineSmiCase(expr->op())) {
+ __ JumpIfSmi(r0, &no_conversion);
+ }
ToNumberStub convert_stub;
__ CallStub(&convert_stub);
__ bind(&no_conversion);
=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Fri Jul 19
04:52:42 2013
+++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Sun Jul 21
22:50:10 2013
@@ -4470,7 +4470,9 @@
// Call ToNumber only if operand is not a smi.
Label no_conversion;
- __ JumpIfSmi(v0, &no_conversion);
+ if (ShouldInlineSmiCase(expr->op())) {
+ __ JumpIfSmi(v0, &no_conversion);
+ }
__ mov(a0, v0);
ToNumberStub convert_stub;
__ CallStub(&convert_stub);
=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Fri Jul 19 04:52:42
2013
+++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Sun Jul 21 22:50:10
2013
@@ -4420,7 +4420,9 @@
// Call ToNumber only if operand is not a smi.
Label no_conversion;
- __ JumpIfSmi(rax, &no_conversion, Label::kNear);
+ if (ShouldInlineSmiCase(expr->op())) {
+ __ JumpIfSmi(rax, &no_conversion, Label::kNear);
+ }
ToNumberStub convert_stub;
__ CallStub(&convert_stub);
__ bind(&no_conversion);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
