https://codereview.chromium.org/17568015/diff/55001/src/hydrogen-bounds-check-removal.cc
File src/hydrogen-bounds-check-removal.cc (right):
https://codereview.chromium.org/17568015/diff/55001/src/hydrogen-bounds-check-removal.cc#newcode101
src/hydrogen-bounds-check-removal.cc:101: if (!next->is_in_loop()) {
This code is now redundant with CheckLoopPaths(Block*).
https://codereview.chromium.org/17568015/diff/55001/src/hydrogen-bounds-check-removal.cc#newcode163
src/hydrogen-bounds-check-removal.cc:163: enum PathCheckResult {
How about HOISTABLE, OPTIMISTICALLY_HOISTABLE, and NOT_HOISTABLE?
https://codereview.chromium.org/17568015/diff/55001/src/hydrogen-bounds-check-removal.cc#newcode180
src/hydrogen-bounds-check-removal.cc:180: PathCheckResult
CheckLoopPaths() {
CheckHoistability?
https://codereview.chromium.org/17568015/diff/55001/src/hydrogen-bounds-check-removal.cc#newcode316
src/hydrogen-bounds-check-removal.cc:316: if (data->increment() <= 0)
continue;
Haven't we already done a whole lot of work to deal with induction
variables that are counting down?
https://codereview.chromium.org/17568015/diff/55001/src/hydrogen-bounds-check-removal.cc#newcode371
src/hydrogen-bounds-check-removal.cc:371: PathCheckResult
CheckLoopPaths(HBasicBlock* block) {
Much improved.
https://codereview.chromium.org/17568015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
