Thanks for the review.
https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.cc#newcode1268
src/deoptimizer.cc:1268: unsigned fixed_frame_entries =
(kPCOnStackSize/kPointerSize) +
On 2013/07/22 21:35:16, danno wrote:
nit here and on following line: spaces left and right of the "/"
Done.
https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h#newcode476
src/deoptimizer.h:476: virtual ~FrameDescription() { }
On 2013/07/22 21:35:16, danno wrote:
No need to make the destructor virtual if there are no virtual methods
(see
below)
Done.
https://codereview.chromium.org/19802002/diff/1/src/deoptimizer.h#newcode514
src/deoptimizer.h:514: virtual void SetCallerPc(unsigned offset,
intptr_t value);
On 2013/07/22 21:35:16, danno wrote:
There is no need to make this function or the following one virtual.
There is a
single implementation for each platform, there is no need for dynamic
dispatch.
Done.
https://codereview.chromium.org/19802002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
