On 2013/07/23 12:28:22, Yury Semikhatsky wrote:
https://codereview.chromium.org/19775017/diff/7002/src/frames.cc
File src/frames.cc (right):
https://codereview.chromium.org/19775017/diff/7002/src/frames.cc#newcode369
src/frames.cc:369: external_callback_scope_ =
external_callback_scope_->previous();
On 2013/07/23 12:15:12, Yang wrote:
> If I understood correctly, the previous external callback scope should
then
have
> a higher address than frame_->fp(), right? Could we assert this?
That's correct. In theory one can allocate two ExternalCallbackScopes in
a row
but this doesn't make sense. Added assert.
lgtm.
https://codereview.chromium.org/19775017/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
