LGTM with comments.
Seeing how similar run-tests.py and run-deopt-fuzzer.py are turning out to
be,
we should probably think about unifying the two at some point (either have a
single script, or factor out more of the shared implementation). But for now
let's keep them separate until deopt fuzzing works fully and the
implementation
has stabilized.
(Later we can also add features that are missing for now, such as networked
execution.)
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py
File tools/run-deopt-fuzzer.py (right):
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode246
tools/run-deopt-fuzzer.py:246: options.distribution_factor1 = 0.0
might want to print a warning here too: "Invalid --distribution-factor1,
defaulting to 0". Same below.
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode320
tools/run-deopt-fuzzer.py:320: return int(math.pow(float(m), (float(m) *
c + l) / (float(m) + l)))
I think you can s/float(m)/m/ three times here.
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode378
tools/run-deopt-fuzzer.py:378: analysis_flags = [
couple nits here:
(1) use proper string formatting
(2) be consistent about use of single vs. double quotes
(3) put related things onto the same line
analysis_flags = ["--deopt-every-n-times", "%d" % MAX_DEOPT,
"--print-deopt-stress"]
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode412
tools/run-deopt-fuzzer.py:412: if line.startswith('=== Stress deopt
counter: '):
nit: ""
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode416
tools/run-deopt-fuzzer.py:416: print "Missing results for " + t.path
print "... %s" % t.path
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode419
tools/run-deopt-fuzzer.py:419: with file(dump_results_file + "." +
str(time.time()), 'w') as f:
file("%s.%d.txt" % (dump_results_file, time.time()), "w")
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode433
tools/run-deopt-fuzzer.py:433: print t.path + " " + str(distribution)
print "%s %s" % (t.path, distribution)
https://codereview.chromium.org/19931005/diff/1/tools/run-deopt-fuzzer.py#newcode435
tools/run-deopt-fuzzer.py:435: fuzzing_flags = ['--deopt-every-n-times',
str(i)]
nit: "" (and ideally: "%d" % i)
https://codereview.chromium.org/19931005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
