https://codereview.chromium.org/20055002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/20055002/diff/1/src/mark-compact.cc#newcode2738
src/mark-compact.cc:2738:
CHECK(heap_->TargetSpace(HeapObject::FromAddress(src)) ==
Please add a TODO here that this should be turned into an ASSERT soon.
We only want this for one or two Canary builds.

Also this ASSERT has nothing to do with this particular location. It has
to hold at method entry after the destination space has been checked
(e.g. at line 2728). Please move it up, out of the loop.

https://codereview.chromium.org/20055002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to