https://codereview.chromium.org/19724007/diff/1/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/19724007/diff/1/src/cpu-profiler.h#newcode187
src/cpu-profiler.h:187: class CpuProfiler : public CodeEventLoggerBase {
Should we add virtual to the overrides for clarity?
https://codereview.chromium.org/19724007/diff/1/src/log.h
File src/log.h (right):
https://codereview.chromium.org/19724007/diff/1/src/log.h#newcode505
src/log.h:505: class CodeEventLogger : public CodeEventLoggerBase {
CodeEventLoggerBase should be CodeEventLogger, and this one should be
CodeEventLoggerImplBase or something like that.
https://codereview.chromium.org/19724007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
