LGTM (with comments).
https://codereview.chromium.org/19638014/diff/11001/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/19638014/diff/11001/src/deoptimizer.cc#newcode346
src/deoptimizer.cc:346: // TODO(titzer): rewrite to not modify
unselected functions.
I am unsure about this TODO, what does this imply?
https://codereview.chromium.org/19638014/diff/11001/src/deoptimizer.cc#newcode472
src/deoptimizer.cc:472: class DeoptimizeMarkedCodeFilter : public
OptimizedFunctionFilter {
nit: Can we move this up to the other filters so that they are grouped
together?
https://codereview.chromium.org/19638014/diff/11001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/19638014/diff/11001/src/mark-compact.cc#newcode3294
src/mark-compact.cc:3294: return code->code_to_deoptimize_link() !=
heap()->undefined_value()
It's only valid to ask this question for optimized code, can we add an
assert in that regard?
https://codereview.chromium.org/19638014/diff/11001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/19638014/diff/11001/src/objects-inl.h#newcode5245
src/objects-inl.h:5245: return Object::cast(READ_FIELD(this,
kTypeFeedbackInfoOffset));
The "Object::cast" is a NOP as READ_FIELD already gives the correct
type, lets drop it.
https://codereview.chromium.org/19638014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
