Reviewers: Yury Semikhatsky, Yang,
Message:
On 2013/07/24 09:15:40, Yury Semikhatsky wrote:
https://codereview.chromium.org/19724007/diff/1/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/19724007/diff/1/src/cpu-profiler.h#newcode187
src/cpu-profiler.h:187: class CpuProfiler : public CodeEventLoggerBase {
Should we add virtual to the overrides for clarity?
https://codereview.chromium.org/19724007/diff/1/src/log.h
File src/log.h (right):
https://codereview.chromium.org/19724007/diff/1/src/log.h#newcode505
src/log.h:505: class CodeEventLogger : public CodeEventLoggerBase {
CodeEventLoggerBase should be CodeEventLogger, and this one should be
CodeEventLoggerImplBase or something like that.
comments addressed
Description:
Logger: introduce abstract interface for CodeEvent listeners.
CodeEventLogger which is the base class for Jit, LowLevel
and CodeAddressMap loggers was renamed to CodeEventLoggerBase.
New abstract class CodeEventLogger was created.
CodeAddressMap class was moved to serializer.cc because serializer is the
only
user for it. Actually it collects code names and pushes them to the
standard log
as SnapshotCodeNameEvent. So I extracted this code into separate function
CodeNameEvent. It happens that this method works only when Serializer
serializes
an object. So I added direct log call there.
CodeEventLoggerBase class declaration was moved to the header
because CodeAddressMap needs it.
The code for the nested class CodeEventLoggerBase::NameBuffer was left in
the cc
file.
CpuProfiler now is inherit CodeEventLoggerBase but not used
the loggers infrastructure yet due to complex initialization schema. I'd
like to
fix that in a separate cl.
BUG=none
TEST=current test set.
Please review this at https://codereview.chromium.org/19724007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/cpu-profiler.h
M src/log.h
M src/log.cc
M src/serialize.h
M src/serialize.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
