On 2013/07/24 12:25:17, Toon Verwaest wrote:
https://codereview.chromium.org/19485008/diff/1/src/ic.cc
File src/ic.cc (right):

https://codereview.chromium.org/19485008/diff/1/src/ic.cc#newcode1318
src/ic.cc:1318: if (constant->IsConsString()) return Handle<Code>::null();
Because we cannot embed cons strings into code. I'll add a comment + TODO.

On 2013/07/24 11:59:45, Yang wrote:
> why do you check for cons string here?

lgtm.

https://codereview.chromium.org/19485008/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to