Revision: 15859
Author: [email protected]
Date: Wed Jul 24 05:38:52 2013
Log: Add --trace-hydrogen-stubs flag (default = false).
BUG=
[email protected]
Review URL: https://codereview.chromium.org/20084003
http://code.google.com/p/v8/source/detail?r=15859
Modified:
/branches/bleeding_edge/src/code-stubs-hydrogen.cc
/branches/bleeding_edge/src/compiler.cc
/branches/bleeding_edge/src/flag-definitions.h
=======================================
--- /branches/bleeding_edge/src/code-stubs-hydrogen.cc Tue Jul 23 06:35:10
2013
+++ /branches/bleeding_edge/src/code-stubs-hydrogen.cc Wed Jul 24 05:38:52
2013
@@ -129,7 +129,7 @@
// Update the static counter each time a new code stub is generated.
isolate()->counters()->code_stubs()->Increment();
- if (FLAG_trace_hydrogen) {
+ if (FLAG_trace_hydrogen_stubs) {
const char* name = CodeStub::MajorName(stub()->MajorKey(), false);
PrintF("-----------------------------------------------------------\n");
PrintF("Compiling stub %s using hydrogen\n", name);
=======================================
--- /branches/bleeding_edge/src/compiler.cc Thu Jul 11 09:45:58 2013
+++ /branches/bleeding_edge/src/compiler.cc Wed Jul 24 05:38:52 2013
@@ -1247,10 +1247,13 @@
bool CompilationPhase::ShouldProduceTraceOutput() const {
- // Produce trace output if flag is set so that the first letter of the
- // phase name matches the command line parameter FLAG_trace_phase.
- return (FLAG_trace_hydrogen &&
- OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) !=
NULL);
+ // Trace if the appropriate trace flag is set and the phase name's first
+ // character is in the FLAG_trace_phase command line parameter.
+ bool tracing_on = info()->IsStub() ?
+ FLAG_trace_hydrogen_stubs :
+ FLAG_trace_hydrogen;
+ return (tracing_on &&
+ OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
}
} } // namespace v8::internal
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Tue Jul 23 02:18:42 2013
+++ /branches/bleeding_edge/src/flag-definitions.h Wed Jul 24 05:38:52 2013
@@ -236,7 +236,8 @@
"crankshaft harvests type feedback from stub cache")
DEFINE_bool(hydrogen_stats, false, "print statistics for hydrogen")
DEFINE_bool(trace_hydrogen, false, "trace generated hydrogen to file")
-DEFINE_string(trace_phase, "Z", "trace generated IR for specified phases")
+DEFINE_bool(trace_hydrogen_stubs, false, "trace generated hydrogen for
stubs")
+DEFINE_string(trace_phase, "HLZ", "trace generated IR for specified
phases")
DEFINE_bool(trace_inlining, false, "trace inlining decisions")
DEFINE_bool(trace_alloc, false, "trace register allocator")
DEFINE_bool(trace_all_uses, false, "trace all use positions")
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
