LGTM with a nit
https://codereview.chromium.org/20274002/diff/1/src/platform-posix.cc
File src/platform-posix.cc (right):
https://codereview.chromium.org/20274002/diff/1/src/platform-posix.cc#newcode215
src/platform-posix.cc:215: if (-1.0 < x && x < 0.0) {
A ternary expresses the functional nature a bit more directly:
return (-1.0 < x && x < 0.0) ? -0.0 : ceil(x);
https://codereview.chromium.org/20274002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
