LGTM with a nit
https://codereview.chromium.org/20070005/diff/21001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/20070005/diff/21001/src/arm/lithium-codegen-arm.cc#newcode501
src/arm/lithium-codegen-arm.cc:501: int
LCodeGen::ToInteger32(LConstantOperand* op) const {
Hmmm, this was here before, but the return type looks wrong. Shouldn't
it be int32_t? (same for other platforms)
https://codereview.chromium.org/20070005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
