LGTM with one comment.
https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-utils.cc
File src/extensions/i18n/i18n-utils.cc (right):
https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-utils.cc#newcode156
src/extensions/i18n/i18n-utils.cc:156:
i::ObjectTemplateInfo::cast(internal->heap()->i18n_template_one()),
Just use internal->i18n_template_one() here, gives you an implicit
handle.
https://codereview.chromium.org/20299002/diff/1/src/extensions/i18n/i18n-utils.cc#newcode174
src/extensions/i18n/i18n-utils.cc:174:
i::ObjectTemplateInfo::cast(internal->heap()->i18n_template_two()),
Likewise.
https://codereview.chromium.org/20299002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
