Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Disable Smi representation support for HMathMinMax
because it's incomplete on x64.
BUG=v8:2808
Please review this at https://codereview.chromium.org/20690002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.h
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
bf59159164c53b4e41ae52ee2d48d76625017a1b..40bbc902458cd70ae79d79cb73f9f3cb85447e98
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -4792,7 +4792,8 @@ class HMathMinMax: public HArithmeticBinaryOperation {
virtual Representation RepresentationFromInputs() {
Representation left_rep = left()->representation();
Representation right_rep = right()->representation();
- Representation result = Representation::Smi();
+ // TODO(verwaest): Initialize to Smi once lithium-codegen has been
fixed.
+ Representation result = Representation::Integer32();
result = result.generalize(left_rep);
result = result.generalize(right_rep);
if (result.IsTagged()) return Representation::Double();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
