LGTM with comment.
Also, I'd really like to see a big test that tests all binary ops against
Smi
inputs (including those that don't support Smis yet, to ensure those cases
are
handled correctly too).
https://chromiumcodereview.appspot.com/20706002/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://chromiumcodereview.appspot.com/20706002/diff/3001/src/x64/lithium-codegen-x64.cc#newcode1711
src/x64/lithium-codegen-x64.cc:1711: __ cmpl(left_reg, right_imm);
This seems brittle. Please add an
ASSERT(!instr->hydrogen_value()->representation().IsSmi()).
https://chromiumcodereview.appspot.com/20706002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
