My comments below apply to all platforms. Please also do the port to ARM,
which
by default runs with an simulator on ia32/x64 so you can run tests without
ARM
hardware:
make arm.check
A MIPS is optional, since the MIPS folks can port your change as they do
other
changes to the core V8 platforms.
https://codereview.chromium.org/21042003/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/21042003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode354
src/ia32/lithium-codegen-ia32.cc:354: if (pos >= 0) RecordPosition(pos);
In order to optimize the size of the source pos tables, don't output the
pos again if it's the same as the pos for the last instruction.
https://codereview.chromium.org/21042003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode356
src/ia32/lithium-codegen-ia32.cc:356: instr->CompileToNative(this);
Not that your solution doesn't handle deferred code correctly, which is
all output at the end of a routine. Please take a look at
GenerateDeferredCode.
https://codereview.chromium.org/21042003/diff/1/src/ia32/lithium-ia32.h
File src/ia32/lithium-ia32.h (right):
https://codereview.chromium.org/21042003/diff/1/src/ia32/lithium-ia32.h#newcode306
src/ia32/lithium-ia32.h:306: int position_;
Please turn this into a bit field with is_call using the BitField class
so that it doesn't use an extra word in the LInstruction class.
https://codereview.chromium.org/21042003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
