https://codereview.chromium.org/21014004/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/21014004/diff/1/src/hydrogen-instructions.cc#newcode3076
src/hydrogen-instructions.cc:3076: void
HCompareObjectAndBranch::PrintDataTo(StringStream* stream) {
We should probably print the token now too, right?

https://codereview.chromium.org/21014004/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/21014004/diff/1/src/hydrogen-instructions.h#newcode4175
src/hydrogen-instructions.h:4175: Token::Value token = Token::EQ) {
I looked, but I couldn't find any uses with the token == NE. We have the
IfBuilder which can do IfNot, so do we need this parameterization?

https://codereview.chromium.org/21014004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to