LGTM (with a nit in the test-case).
https://codereview.chromium.org/20992005/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/20992005/diff/1/test/cctest/test-api.cc#newcode1570
test/cctest/test-api.cc:1570: //
CHECK(false_boolean_object->BooleanValue());
Let's add a TODO here that this line should be enabled once
BooleanObject::BooleanValue is deprecated _and_ removed.
https://codereview.chromium.org/20992005/diff/1/test/cctest/test-api.cc#newcode1592
test/cctest/test-api.cc:1592: //
CHECK(true_boolean_object->BooleanValue());
Likewise.
https://codereview.chromium.org/20992005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
