https://codereview.chromium.org/21101002/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/21101002/diff/1/src/cpu-profiler.cc#newcode175
src/cpu-profiler.cc:175: ProcessEventsAndYield();
I think there are two severe issues with this loop, first of all
running_ is not volatile and there's no memory barrier for running_. And
YieldCPU() should not be used. Maybe unrelated to the change at hand,
but how about using proper synchronization primitives (i.e.
monitors/condition variables or semaphores) instead?
https://codereview.chromium.org/21101002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
