Lgtm with nit.
https://codereview.chromium.org/21105006/diff/8001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/21105006/diff/8001/src/hydrogen-instructions.cc#newcode4379
src/hydrogen-instructions.cc:4379: && !use_rep.IsTagged()) return true;
Nit: use new lines for each of the three cases, put the && at the end of
the line rather than the start, and put {} around the true case.
Otherwise you could also just check for Integer32 and Double instead.
https://codereview.chromium.org/21105006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
