PTAL
https://codereview.chromium.org/21065003/diff/15001/src/hydrogen-mark-deoptimize.cc
File src/hydrogen-mark-deoptimize.cc (right):
https://codereview.chromium.org/21065003/diff/15001/src/hydrogen-mark-deoptimize.cc#newcode51
src/hydrogen-mark-deoptimize.cc:51: void
HMarkDeoptimizeOnUndefinedPhase::AddToWorklist(HPhi* phi) {
On 2013/07/30 09:05:24, Dmitry Lomov (chromium) wrote:
Any reason to have AddToWorklist function at all? I would do it this
way:
- Rename ProcessWorklist into ProcessPhi
- Pass phi to ProcessPhi and make worklist local to ProcessPhiTree
- Remove global worklist
As discussed offline: The idea is to avoid allocating a new ZoneList for
every phi with an affected use. The way its done now reuses the same
ZoneList. I'll merge the AddToWorklist and ProcessWorklist methods into
a single ProcessPhi method, using the member ZoneList as optimization.
https://codereview.chromium.org/21065003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
