LGTM (with one nit).

https://codereview.chromium.org/21216003/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/21216003/diff/1/src/heap.cc#newcode6958
src/heap.cc:6958: mark_compact_collector()->AbortCompaction();
nit: Can we add a MarkCompactCollector::TearDown method that takes care
this and call this method from here? Just one additional indirection,
but better abstraction.

https://codereview.chromium.org/21216003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to