LGTM if the scope change mentioned below is OK.
https://codereview.chromium.org/21087012/diff/8001/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/21087012/diff/8001/src/isolate.cc#newcode373
src/isolate.cc:373: per_thread =
AllocatePerIsolateThreadData(thread_id);
Why is it OK to move this outside the ScopedLock?
https://codereview.chromium.org/21087012/diff/8001/src/mutex.h
File src/mutex.h (right):
https://codereview.chromium.org/21087012/diff/8001/src/mutex.h#newcode106
src/mutex.h:106: class ScopedLock {
It would be cool if we could restrict the usage of Mutexes to this
class, i.e. without public Lock/Unlock methods, but I guess we are not
really there yet...
https://codereview.chromium.org/21087012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
