[v8-dev] Reenable tests that need to access the default timezone. (issue 21512002)

Thu, 01 Aug 2013 02:18:26 -0700 

Reviewers: Michael Starzinger,

Description:
Reenable tests that need to access the default timezone.

It's now available via builtins.

BUG=v8:2475
[email protected]

Please review this at https://codereview.chromium.org/21512002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M test/intl/break-iterator/default-locale.js
  M test/intl/break-iterator/wellformed-unsupported-locale.js
  M test/intl/collator/default-locale.js
  M test/intl/collator/wellformed-unsupported-locale.js
  M test/intl/date-format/default-locale.js
  M test/intl/date-format/wellformed-unsupported-locale.js
  M test/intl/intl.status
  M test/intl/number-format/default-locale.js
  M test/intl/number-format/wellformed-unsupported-locale.js
  M test/intl/testcfg.py


Index: test/intl/break-iterator/default-locale.js
diff --git a/test/intl/break-iterator/default-locale.js b/test/intl/break-iterator/default-locale.js index 39a88574fe19efabf017fbad4d4597430bf70811..d8d5aeadb2751059d8119a46735132be0474a6a5 100644 
--- a/test/intl/break-iterator/default-locale.js
+++ b/test/intl/break-iterator/default-locale.js
@@ -38,7 +38,7 @@ assertFalse(options.locale === '');
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var iteratorNone = new Intl.v8BreakIterator();
 assertEquals(options.locale, iteratorNone.resolvedOptions().locale);
Index: test/intl/break-iterator/wellformed-unsupported-locale.js
diff --git a/test/intl/break-iterator/wellformed-unsupported-locale.js b/test/intl/break-iterator/wellformed-unsupported-locale.js index 56457b4829239944eeca79e8cee0de9498df1c5f..5ac8fbcd41583f0b36df0b54bd8cae47331f6097 100644 
--- a/test/intl/break-iterator/wellformed-unsupported-locale.js
+++ b/test/intl/break-iterator/wellformed-unsupported-locale.js
@@ -29,4 +29,4 @@

 var iterator = Intl.v8BreakIterator(['xx']);

-assertEquals(iterator.resolvedOptions().locale, getDefaultLocale());
+assertEquals(iterator.resolvedOptions().locale, %GetDefaultICULocale());
Index: test/intl/collator/default-locale.js
diff --git a/test/intl/collator/default-locale.js b/test/intl/collator/default-locale.js index f6ffba8e1d86a5082b6097b01a0e4bfef2b45ca3..db9b1e73304114df4c52933841899f895df1af30 100644 
--- a/test/intl/collator/default-locale.js
+++ b/test/intl/collator/default-locale.js
@@ -38,7 +38,7 @@ assertFalse(options.locale === '');
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var collatorNone = new Intl.Collator();
 assertEquals(options.locale, collatorNone.resolvedOptions().locale);
@@ -48,5 +48,5 @@ var collatorBraket = new Intl.Collator({});
 assertEquals(options.locale, collatorBraket.resolvedOptions().locale);

 var collatorWithOptions = new Intl.Collator(undefined, {usage: 'search'});
-assertEquals(getDefaultLocale() + '-u-co-search',
+assertEquals(%GetDefaultICULocale() + '-u-co-search',
              collatorWithOptions.resolvedOptions().locale);
Index: test/intl/collator/wellformed-unsupported-locale.js
diff --git a/test/intl/collator/wellformed-unsupported-locale.js b/test/intl/collator/wellformed-unsupported-locale.js index ea143fdc6375761c469e399a789c0afc8fc54389..3963d47a61ff85b1cc491a904533e955110d972d 100644 
--- a/test/intl/collator/wellformed-unsupported-locale.js
+++ b/test/intl/collator/wellformed-unsupported-locale.js
@@ -29,4 +29,4 @@

 var collator = Intl.Collator(['xx']);

-assertEquals(collator.resolvedOptions().locale, getDefaultLocale());
+assertEquals(collator.resolvedOptions().locale, %GetDefaultICULocale());
Index: test/intl/date-format/default-locale.js
diff --git a/test/intl/date-format/default-locale.js b/test/intl/date-format/default-locale.js index 2dcb0f8ae7463832d1d08c4ebe617718cd4454b4..8e9b7fcec3e16e0bc4a6ce18d1584d0664f3f02e 100644 
--- a/test/intl/date-format/default-locale.js
+++ b/test/intl/date-format/default-locale.js
@@ -38,7 +38,7 @@ assertFalse(options.locale === '');
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var dtfNone = new Intl.DateTimeFormat();
 assertEquals(options.locale, dtfNone.resolvedOptions().locale);
Index: test/intl/date-format/wellformed-unsupported-locale.js
diff --git a/test/intl/date-format/wellformed-unsupported-locale.js b/test/intl/date-format/wellformed-unsupported-locale.js index 8867ec644294ddc3e5ef8b8e8f5ac600284a91db..6f063abbd1a07c404bb4481633ce0e2d03f26d53 100644 
--- a/test/intl/date-format/wellformed-unsupported-locale.js
+++ b/test/intl/date-format/wellformed-unsupported-locale.js
@@ -29,4 +29,4 @@

 var dtf = Intl.DateTimeFormat(['xx']);

-assertEquals(dtf.resolvedOptions().locale, getDefaultLocale());
+assertEquals(dtf.resolvedOptions().locale, %GetDefaultICULocale());
Index: test/intl/intl.status
diff --git a/test/intl/intl.status b/test/intl/intl.status
index 913626b1f4b61a81530de0847500e208a9ea2379..7ef0abb4d2fe8f2dadedd7822d521da4768e72a3 100644 
--- a/test/intl/intl.status
+++ b/test/intl/intl.status
@@ -27,15 +27,7 @@

 prefix intl

-# The following tests use getDefaultLocale() or getDefaultTimezone().
-break-iterator/default-locale: FAIL
-break-iterator/wellformed-unsupported-locale: FAIL
-collator/default-locale: FAIL
-collator/wellformed-unsupported-locale: FAIL
-date-format/default-locale: FAIL
+# The following tests use getDefaultTimeZone().
 date-format/resolved-options: FAIL
 date-format/timezone: FAIL
-date-format/wellformed-unsupported-locale: FAIL
 general/v8Intl-exists: FAIL
-number-format/default-locale: FAIL
-number-format/wellformed-unsupported-locale: FAIL
Index: test/intl/number-format/default-locale.js
diff --git a/test/intl/number-format/default-locale.js b/test/intl/number-format/default-locale.js index 0d5e24dd70628e86385af4b9b50fad1bab332d69..cd67ba724f140ff98d4afe6a726d6cd4f0d5f146 100644 
--- a/test/intl/number-format/default-locale.js
+++ b/test/intl/number-format/default-locale.js
@@ -38,7 +38,7 @@ assertFalse(options.locale === '');
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var nfNone = new Intl.NumberFormat();
 assertEquals(options.locale, nfNone.resolvedOptions().locale);
Index: test/intl/number-format/wellformed-unsupported-locale.js
diff --git a/test/intl/number-format/wellformed-unsupported-locale.js b/test/intl/number-format/wellformed-unsupported-locale.js index e3fe9cc087fa08282a5b4deef6deacd39b8ec25b..195eba4c19e09b218381727a4eeb4302338163c0 100644 
--- a/test/intl/number-format/wellformed-unsupported-locale.js
+++ b/test/intl/number-format/wellformed-unsupported-locale.js
@@ -29,4 +29,4 @@

 var nf = Intl.NumberFormat(['xx']);

-assertEquals(nf.resolvedOptions().locale, getDefaultLocale());
+assertEquals(nf.resolvedOptions().locale, %GetDefaultICULocale());
Index: test/intl/testcfg.py
diff --git a/test/intl/testcfg.py b/test/intl/testcfg.py
index d25683bed2c752500054f73b60107b1a7bebddff..09d29d0bee066d1fea8e5591ba589a403c537bb4 100644 
--- a/test/intl/testcfg.py
+++ b/test/intl/testcfg.py
@@ -52,7 +52,7 @@ class IntlTestSuite(testsuite.TestSuite):
     return tests

   def GetFlagsForTestCase(self, testcase, context):
-    flags = [] + context.mode_flags
+    flags = ["--allow-natives-syntax"] + context.mode_flags

     files = []
     files.append(os.path.join(self.root, "assert.js"))


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to