LGTM (with nits). I didn't actually review the implementation of the runtime
methods, but I assume it's a straight copy of the existing ones.
https://codereview.chromium.org/21499003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/21499003/diff/1/src/runtime.cc#newcode13377
src/runtime.cc:13377:
nit: Can we add asserts that check the number of arguments for
correctness?
ASSERT(args.length() == 1);
https://codereview.chromium.org/21499003/diff/1/src/runtime.cc#newcode13410
src/runtime.cc:13410:
Likewise.
https://codereview.chromium.org/21499003/diff/1/src/runtime.cc#newcode13456
src/runtime.cc:13456:
Likewise.
https://codereview.chromium.org/21499003/diff/1/src/runtime.cc#newcode13474
src/runtime.cc:13474:
Likewise.
https://codereview.chromium.org/21499003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
