I like this change. Lgtm with some nits.
https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc#newcode4902
src/ia32/lithium-codegen-ia32.cc:4902: } else {
else if
https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc#newcode5447
src/ia32/lithium-codegen-ia32.cc:5447: if
(instr->hydrogen()->value()->representation().IsSmi()) {
This is probably also relevant on other platforms?
Seems unrelated to this CL however.
https://codereview.chromium.org/20781007/diff/8001/src/ia32/lithium-codegen-ia32.cc#newcode5710
src/ia32/lithium-codegen-ia32.cc:5710: __ bind(&done);
Make the done label available in the top-level scope of the function, so
you don't need to duplicate it in the individual branches. Same in other
functions.
https://codereview.chromium.org/20781007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
