LGTM with comment.
https://codereview.chromium.org/21495005/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/21495005/diff/1/src/ia32/lithium-ia32.cc#newcode814
src/ia32/lithium-ia32.cc:814: if (op == Token::MOD) return
MarkAsCall(DefineSameAsFirst(result), instr);
Why DefineSameAsFirst? I think DefineAsRegister would be more
appropriate.
https://codereview.chromium.org/21495005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
