On 2013/07/31 17:12:58, Jakob wrote:
Drive-by LGTM with a comment.
https://codereview.chromium.org/21103011/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/21103011/diff/1/src/hydrogen.cc#newcode3016
src/hydrogen.cc:3016: // TODO(titzer): this phase shouldn't be needed
after
IDEFs are gone.
Right now it is still needed, because some other instructions rely on it.
IIRC
HBoundsChecks are an example: during the other Hydrogen phases, they need
to
be
in the def-use chain (index -> bounds check -> array access), but from
Lithium's
point of view they don't produce a value, so we "restore" the original
index
as
an input to the array access during this phase, turning the bounds check
into
a
(non-dead!) leaf in the dependency graph.
Of course that could be cleaned up in some other way; but what we had
before
was
even worse ;-)
TODO removed
https://codereview.chromium.org/21103011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
