Revision: 16016
Author:   [email protected]
Date:     Thu Aug  1 12:43:06 2013
Log:      Reenable tests that need to access the default timezone.

It's now available via builtins.

BUG=v8:2475
[email protected]

Review URL: https://codereview.chromium.org/21512002
http://code.google.com/p/v8/source/detail?r=16016

Modified:
 /branches/bleeding_edge/test/intl/break-iterator/default-locale.js
/branches/bleeding_edge/test/intl/break-iterator/wellformed-unsupported-locale.js
 /branches/bleeding_edge/test/intl/collator/default-locale.js
 /branches/bleeding_edge/test/intl/collator/wellformed-unsupported-locale.js
 /branches/bleeding_edge/test/intl/date-format/default-locale.js
/branches/bleeding_edge/test/intl/date-format/wellformed-unsupported-locale.js
 /branches/bleeding_edge/test/intl/intl.status
 /branches/bleeding_edge/test/intl/number-format/default-locale.js
/branches/bleeding_edge/test/intl/number-format/wellformed-unsupported-locale.js
 /branches/bleeding_edge/test/intl/testcfg.py

=======================================
--- /branches/bleeding_edge/test/intl/break-iterator/default-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/break-iterator/default-locale.js Thu Aug 1 12:43:06 2013
@@ -38,7 +38,7 @@
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var iteratorNone = new Intl.v8BreakIterator();
 assertEquals(options.locale, iteratorNone.resolvedOptions().locale);
=======================================
--- /branches/bleeding_edge/test/intl/break-iterator/wellformed-unsupported-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/break-iterator/wellformed-unsupported-locale.js Thu Aug 1 12:43:06 2013
@@ -29,4 +29,4 @@

 var iterator = Intl.v8BreakIterator(['xx']);

-assertEquals(iterator.resolvedOptions().locale, getDefaultLocale());
+assertEquals(iterator.resolvedOptions().locale, %GetDefaultICULocale());
=======================================
--- /branches/bleeding_edge/test/intl/collator/default-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/collator/default-locale.js Thu Aug 1 12:43:06 2013
@@ -38,7 +38,7 @@
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var collatorNone = new Intl.Collator();
 assertEquals(options.locale, collatorNone.resolvedOptions().locale);
@@ -48,5 +48,5 @@
 assertEquals(options.locale, collatorBraket.resolvedOptions().locale);

 var collatorWithOptions = new Intl.Collator(undefined, {usage: 'search'});
-assertEquals(getDefaultLocale() + '-u-co-search',
+assertEquals(%GetDefaultICULocale() + '-u-co-search',
              collatorWithOptions.resolvedOptions().locale);
=======================================
--- /branches/bleeding_edge/test/intl/collator/wellformed-unsupported-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/collator/wellformed-unsupported-locale.js Thu Aug 1 12:43:06 2013
@@ -29,4 +29,4 @@

 var collator = Intl.Collator(['xx']);

-assertEquals(collator.resolvedOptions().locale, getDefaultLocale());
+assertEquals(collator.resolvedOptions().locale, %GetDefaultICULocale());
=======================================
--- /branches/bleeding_edge/test/intl/date-format/default-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/date-format/default-locale.js Thu Aug 1 12:43:06 2013
@@ -38,7 +38,7 @@
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var dtfNone = new Intl.DateTimeFormat();
 assertEquals(options.locale, dtfNone.resolvedOptions().locale);
=======================================
--- /branches/bleeding_edge/test/intl/date-format/wellformed-unsupported-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/date-format/wellformed-unsupported-locale.js Thu Aug 1 12:43:06 2013
@@ -29,4 +29,4 @@

 var dtf = Intl.DateTimeFormat(['xx']);

-assertEquals(dtf.resolvedOptions().locale, getDefaultLocale());
+assertEquals(dtf.resolvedOptions().locale, %GetDefaultICULocale());
=======================================
--- /branches/bleeding_edge/test/intl/intl.status       Thu Aug  1 12:20:42 2013
+++ /branches/bleeding_edge/test/intl/intl.status       Thu Aug  1 12:43:06 2013
@@ -27,14 +27,7 @@

 prefix intl

-# The following tests use getDefaultLocale() or getDefaultTimezone().
-break-iterator/default-locale: FAIL
-break-iterator/wellformed-unsupported-locale: FAIL
-collator/default-locale: FAIL
-collator/wellformed-unsupported-locale: FAIL
-date-format/default-locale: FAIL
+# The following tests use getDefaultTimeZone().
 date-format/resolved-options: FAIL
 date-format/timezone: FAIL
-date-format/wellformed-unsupported-locale: FAIL
-number-format/default-locale: FAIL
-number-format/wellformed-unsupported-locale: FAIL
+general/v8Intl-exists: FAIL
=======================================
--- /branches/bleeding_edge/test/intl/number-format/default-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/number-format/default-locale.js Thu Aug 1 12:43:06 2013
@@ -38,7 +38,7 @@
 assertFalse(options.locale === undefined);

 // Then check for equality.
-assertEquals(options.locale, getDefaultLocale());
+assertEquals(options.locale, %GetDefaultICULocale());

 var nfNone = new Intl.NumberFormat();
 assertEquals(options.locale, nfNone.resolvedOptions().locale);
=======================================
--- /branches/bleeding_edge/test/intl/number-format/wellformed-unsupported-locale.js Wed Jul 10 03:49:04 2013 +++ /branches/bleeding_edge/test/intl/number-format/wellformed-unsupported-locale.js Thu Aug 1 12:43:06 2013
@@ -29,4 +29,4 @@

 var nf = Intl.NumberFormat(['xx']);

-assertEquals(nf.resolvedOptions().locale, getDefaultLocale());
+assertEquals(nf.resolvedOptions().locale, %GetDefaultICULocale());
=======================================
--- /branches/bleeding_edge/test/intl/testcfg.py        Wed Jul 10 03:49:04 2013
+++ /branches/bleeding_edge/test/intl/testcfg.py        Thu Aug  1 12:43:06 2013
@@ -52,7 +52,7 @@
     return tests

   def GetFlagsForTestCase(self, testcase, context):
-    flags = [] + context.mode_flags
+    flags = ["--allow-natives-syntax"] + context.mode_flags

     files = []
     files.append(os.path.join(self.root, "assert.js"))

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to