Revision: 16018
Author: [email protected]
Date: Fri Aug 2 00:58:23 2013
Log: Revert windows-specific part of r15937 for debug level 1.
The change in r15937 might have broken a mozilla test under windows. See
https://codereview.chromium.org/19384011/
Each case of debug 0,1,2 is now stated explicitly for better clarity in the
msvs section. This causes some minor code duplications, which we can
squeeze again after toolchain.gypi is in a stable state.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/21495002
http://code.google.com/p/v8/source/detail?r=16018
Modified:
/branches/bleeding_edge/build/toolchain.gypi
=======================================
--- /branches/bleeding_edge/build/toolchain.gypi Mon Jul 29 07:00:06 2013
+++ /branches/bleeding_edge/build/toolchain.gypi Fri Aug 2 00:58:23 2013
@@ -61,11 +61,10 @@
'v8_enable_backtrace%': 0,
# Speeds up Debug builds:
- # 0 - compiler optimizations off (debuggable) (default). This may
+ # 0 - Compiler optimizations off (debuggable) (default). This may
# be 5x slower than Release (or worse).
- # 1 - turn on compiler optimizations. and #undef DEBUG/#define NDEBUG.
- # This may be hard or impossible to debug. This may still be
- # 2x slower than Release (or worse).
+ # 1 - Turn on compiler optimizations. This may be hard or impossible to
+ # debug. This may still be 2x slower than Release (or worse).
# 2 - Turn on optimizations, and also #undef DEBUG / #define NDEBUG
# (but leave V8_ENABLE_CHECKS and most other assertions enabled.
# This may cause some v8 tests to fail in the Debug configuration.
@@ -455,14 +454,32 @@
'msvs_settings': {
'VCCLCompilerTool': {
'conditions': [
- ['component=="shared_library"', {
- 'RuntimeLibrary': '3', # /MDd
- }, {
- 'RuntimeLibrary': '1', # /MTd
- }],
['v8_optimized_debug==0', {
'Optimization': '0',
- }, {
+ 'conditions': [
+ ['component=="shared_library"', {
+ 'RuntimeLibrary': '3', # /MDd
+ }, {
+ 'RuntimeLibrary': '1', # /MTd
+ }],
+ ],
+ }],
+ ['v8_optimized_debug==1', {
+ 'Optimization': '1',
+ 'InlineFunctionExpansion': '2',
+ 'EnableIntrinsicFunctions': 'true',
+ 'FavorSizeOrSpeed': '0',
+ 'StringPooling': 'true',
+ 'BasicRuntimeChecks': '0',
+ 'conditions': [
+ ['component=="shared_library"', {
+ 'RuntimeLibrary': '3', # /MDd
+ }, {
+ 'RuntimeLibrary': '1', # /MTd
+ }],
+ ],
+ }],
+ ['v8_optimized_debug==2', {
'Optimization': '2',
'InlineFunctionExpansion': '2',
'EnableIntrinsicFunctions': 'true',
@@ -487,7 +504,11 @@
'conditions': [
['v8_optimized_debug==0', {
'LinkIncremental': '2',
- }, {
+ }],
+ ['v8_optimized_debug==1', {
+ 'LinkIncremental': '2',
+ }],
+ ['v8_optimized_debug==2', {
'LinkIncremental': '1',
'OptimizeReferences': '2',
'EnableCOMDATFolding': '2',
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
