LGTM with a nit
https://codereview.chromium.org/21771002/diff/1/Makefile
File Makefile (right):
https://codereview.chromium.org/21771002/diff/1/Makefile#newcode408
Makefile:408: @cat $(DUMP_FILE).tmpl >$(DUMP_FILE)
Nit: A space between ">" and "$" makes things more readable. Same below.
Otherwise things look a bit like automatic variables
http://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html
:-)
https://codereview.chromium.org/21771002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
