Revision: 16026
Author:   [email protected]
Date:     Fri Aug  2 03:59:23 2013
Log:      Make optimized debug builds link against debug CRT.

We recently had some XP issues on chromium.win after https://codereview.chromium.org/19384011/.

This might fix it - quote: "The most likely cause of the problem is a gyp (or similar) change that resulted in v8.dll linking against the release version of the crt (for a debug build). There are two MS VC related files: the crt and the c++ std lib (MSVCR100.DLL and MSVCP100D.DLL). The former is set to release, the latter to debug."

I am not entirely sure if this change fits to the linker options for debug level 2.

[email protected]

Review URL: https://codereview.chromium.org/21776002
http://code.google.com/p/v8/source/detail?r=16026

Modified:
 /branches/bleeding_edge/build/toolchain.gypi

=======================================
--- /branches/bleeding_edge/build/toolchain.gypi        Fri Aug  2 00:58:23 2013
+++ /branches/bleeding_edge/build/toolchain.gypi        Fri Aug  2 03:59:23 2013
@@ -488,9 +488,9 @@
                 'BasicRuntimeChecks': '0',
                 'conditions': [
                   ['component=="shared_library"', {
-                    'RuntimeLibrary': '2',  #/MD
+                    'RuntimeLibrary': '3',  #/MDd
                   }, {
-                    'RuntimeLibrary': '0',  #/MT
+                    'RuntimeLibrary': '1',  #/MTd
                   }],
                   ['v8_target_arch=="x64"', {
                     # TODO(2207): remove this option once the bug is fixed.

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to