Much better, a few more comments and nits.
https://codereview.chromium.org/21042004/diff/25001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/21042004/diff/25001/src/global-handles.cc#newcode316
src/global-handles.cc:316: : anchor_(anchor), current_(anchor->next()) {
nit: Indentation is off.
https://codereview.chromium.org/21042004/diff/25001/src/global-handles.cc#newcode689
src/global-handles.cc:689: BlockList* anchors[2] = { &full_blocks_,
&non_full_blocks_ };
Can we hoist out this list of anchors to be a field on GlobalHandles so
that we have a single place where all anchors are defined?
https://codereview.chromium.org/21042004/diff/25001/src/global-handles.cc#newcode902
src/global-handles.cc:902: BlockList* anchors[2] = {&full_blocks_,
&non_full_blocks_};
See comment about.
https://codereview.chromium.org/21042004/diff/25001/src/global-handles.h
File src/global-handles.h (right):
https://codereview.chromium.org/21042004/diff/25001/src/global-handles.h#newcode328
src/global-handles.h:328: int LengthOfFreeList();
nit: Indentation is off.
https://codereview.chromium.org/21042004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
