This CL is missing something: In HOptimizedGraphBuilder::BuildBinaryOperation we want to transform an BIT_XOR with a ~0 back into an HBitNot, otherwise we lose
some optimizations, e.g. ~~x => x.

https://codereview.chromium.org/21813010/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/21813010/diff/1/src/parser.cc#newcode3211
src/parser.cc:3211: factory()->NewNumberLiteral(-1),
Replace the -1 by ~0 here and in the comment, it's a bit clearer.

https://codereview.chromium.org/21813010/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to