Reviewers: Jakob,

Message:
On 2013/08/05 09:27:03, Jakob wrote:
LGTM with wording nit: "is" xor "has been"

thanks. fixed.

Description:
Add notice when parallel recompilation is disabled by tracing.

BUG=

Please review this at https://codereview.chromium.org/22164002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/v8.cc


Index: src/v8.cc
diff --git a/src/v8.cc b/src/v8.cc
index 521d064129a32631eedeaec02c4e44eb5e2c2fa5..e559bcac4e14100f4b98d2c7b1f37faf45080107 100644
--- a/src/v8.cc
+++ b/src/v8.cc
@@ -272,9 +272,10 @@ void V8::InitializeOncePerProcessImpl() {
     FLAG_max_new_space_size = (1 << (kPageSizeBits - 10)) * 2;
   }

-  if (FLAG_trace_hydrogen || FLAG_trace_hydrogen_stubs) {
-    // Tracing hydrogen do not work with parallel recompilation.
+  if (FLAG_parallel_recompilation &&
+      (FLAG_trace_hydrogen || FLAG_trace_hydrogen_stubs)) {
     FLAG_parallel_recompilation = false;
+    PrintF("Parallel recompilation is has been disabled for tracing.\n");
   }

   if (FLAG_sweeper_threads <= 0) {


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to