Revision: 16058
Author: [email protected]
Date: Mon Aug 5 09:47:45 2013
Log: Use first hit when dumping heap constants.
This makes sure that the first hit is used when dumping heap constants
and hence "TheHoleValue" is not overwritten with other roots that are
initialized to the hole as well.
[email protected]
Review URL: https://codereview.chromium.org/21639004
http://code.google.com/p/v8/source/detail?r=16058
Modified:
/branches/bleeding_edge/src/d8.cc
/branches/bleeding_edge/tools/v8heapconst.py
=======================================
--- /branches/bleeding_edge/src/d8.cc Fri Aug 2 06:03:06 2013
+++ /branches/bleeding_edge/src/d8.cc Mon Aug 5 09:47:45 2013
@@ -1583,9 +1583,9 @@
// Dump the KNOWN_MAP table to the console.
printf("\n# List of known V8 maps.\n");
#define ROOT_LIST_CASE(type, name, camel_name) \
- if (o == heap->name()) n = #camel_name;
+ if (n == NULL && o == heap->name()) n = #camel_name;
#define STRUCT_LIST_CASE(upper_name, camel_name, name) \
- if (o == heap->name##_map()) n = #camel_name "Map";
+ if (n == NULL && o == heap->name##_map()) n = #camel_name "Map";
i::HeapObjectIterator it(heap->map_space());
printf("KNOWN_MAPS = {\n");
for (i::Object* o = it.Next(); o != NULL; o = it.Next()) {
@@ -1605,7 +1605,7 @@
// Dump the KNOWN_OBJECTS table to the console.
printf("\n# List of known V8 objects.\n");
#define ROOT_LIST_CASE(type, name, camel_name) \
- if (o == heap->name()) n = #camel_name;
+ if (n == NULL && o == heap->name()) n = #camel_name;
i::OldSpaces spit(heap);
printf("KNOWN_OBJECTS = {\n");
for (i::PagedSpace* s = spit.next(); s != NULL; s = spit.next()) {
=======================================
--- /branches/bleeding_edge/tools/v8heapconst.py Mon Aug 5 02:46:23 2013
+++ /branches/bleeding_edge/tools/v8heapconst.py Mon Aug 5 09:47:45 2013
@@ -208,7 +208,7 @@
KNOWN_OBJECTS = {
("OLD_POINTER_SPACE", 0x08081): "NullValue",
("OLD_POINTER_SPACE", 0x08091): "UndefinedValue",
- ("OLD_POINTER_SPACE", 0x080a1): "InstanceofCacheMap",
+ ("OLD_POINTER_SPACE", 0x080a1): "TheHoleValue",
("OLD_POINTER_SPACE", 0x080b1): "TrueValue",
("OLD_POINTER_SPACE", 0x080c1): "FalseValue",
("OLD_POINTER_SPACE", 0x080d1): "UninitializedValue",
@@ -231,7 +231,7 @@
("OLD_POINTER_SPACE", 0x0e0a1): "ElementsTransitionSymbol",
("OLD_POINTER_SPACE", 0x0e0ad): "EmptySlowElementDictionary",
("OLD_POINTER_SPACE", 0x0e249): "ObservedSymbol",
- ("OLD_POINTER_SPACE", 0x27631): "StringTable",
+ ("OLD_POINTER_SPACE", 0x27585): "StringTable",
("OLD_DATA_SPACE", 0x08099): "EmptyDescriptorArray",
("OLD_DATA_SPACE", 0x080a1): "EmptyFixedArray",
("OLD_DATA_SPACE", 0x080a9): "NanValue",
@@ -247,6 +247,6 @@
("OLD_DATA_SPACE", 0x082c9): "EmptyExternalPixelArray",
("OLD_DATA_SPACE", 0x082d5): "InfinityValue",
("OLD_DATA_SPACE", 0x082e1): "MinusZeroValue",
- ("CODE_SPACE", 0x0e801): "JsConstructEntryCode",
- ("CODE_SPACE", 0x176e1): "JsEntryCode",
+ ("CODE_SPACE", 0x0eb41): "JsConstructEntryCode",
+ ("CODE_SPACE", 0x177a1): "JsEntryCode",
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
