On 2013/08/05 16:26:41, Sven Panne wrote:
NOT LGTM. Wouldn't it be much simpler to keep the one-and-only definition
in
include/v8.h and remove the #undef plus the copies of the CPP madness
instead?
That was my initial intent but then I found that v8-preparser.h doesn't
include
v8.h and decided that it would be better to move this into a separate
header. If
we are OK with including v8.h into v8-preparser.h then I'll upload another
CL
that does what you suggest.
I don't think that #undef'ing something we #define'd before will help
anybody.
A
much more common, simple rule is to reserve a prefix for #defines in the
external headers (e.g. GL_ for OpenGL etc.).
Absolutely agree, this also would match what our approach in Chromium and
Blink.
Therefore I propose to drop this CL and make a differente CL that makes
all
our
macros have a V8_ prefix + drop copies of redundant macros. No #undefs
involved.
https://codereview.chromium.org/22093003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
