LGTM (with comments).
https://codereview.chromium.org/22184004/diff/1/src/hydrogen-uint32-analysis.cc
File src/hydrogen-uint32-analysis.cc (right):
https://codereview.chromium.org/22184004/diff/1/src/hydrogen-uint32-analysis.cc#newcode36
src/hydrogen-uint32-analysis.cc:36: if (use->IsBitwise() ||
nit: Condition should fit into one line now.
https://codereview.chromium.org/22184004/diff/1/src/objects.h
File src/objects.h (left):
https://codereview.chromium.org/22184004/diff/1/src/objects.h#oldcode4993
src/objects.h:4993: // [type-recording unary op type]: For kind
UNARY_OP_IC.
It should be possible to remove the UNARY_OP_IC from the IC_KIND_LIST
now.
https://codereview.chromium.org/22184004/diff/1/src/runtime.js
File src/runtime.js (left):
https://codereview.chromium.org/22184004/diff/1/src/runtime.js#oldcode300
src/runtime.js:300: return %NumberNot(x);
I would be tempted to leave this BIT_NOT runtime function in. Or, if we
rip it out, also rip out the Runtime_NumberNot supporting function.
Either way, one doesn't make sense without the other.
https://codereview.chromium.org/22184004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
