LGTM with comments.
https://codereview.chromium.org/22381003/diff/5001/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/22381003/diff/5001/tools/run-tests.py#newcode97
tools/run-tests.py:97: result.add_option("--classification",
"classification" is too generic. How about "--flaky-tests" or
"--run-flaky-tests" instead? The options' names could stay the same.
https://codereview.chromium.org/22381003/diff/5001/tools/testrunner/local/testsuite.py
File tools/testrunner/local/testsuite.py (right):
https://codereview.chromium.org/22381003/diff/5001/tools/testrunner/local/testsuite.py#newcode70
tools/testrunner/local/testsuite.py:70: return
testcase.path.replace("\\", "/")
Good catch!
https://codereview.chromium.org/22381003/diff/5001/tools/testrunner/local/testsuite.py#newcode92
tools/testrunner/local/testsuite.py:92: return cls == "flaky" and not
flaky or cls == "non-flaky" and flaky
I'm paranoid about operator precedence. Please add ():
return (cls == "flaky" and not flaky) or (cls == "non-flaky" and
flaky)
https://codereview.chromium.org/22381003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
