LGTM with some comments
https://codereview.chromium.org/21055011/diff/28001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/21055011/diff/28001/src/heap.cc#newcode4516
src/heap.cc:4516: Map* map, PretenureFlag pretenure) {
Seems to be a lot of overlap with the above function. Can we factor that
out somehow, maybe even have one function that can do both?
https://codereview.chromium.org/21055011/diff/28001/src/hydrogen-escape-analysis.cc
File src/hydrogen-escape-analysis.cc (right):
https://codereview.chromium.org/21055011/diff/28001/src/hydrogen-escape-analysis.cc#newcode224
src/hydrogen-escape-analysis.cc:224: // is not a HConstant. Find a repro
test case and fix this.
Could it be the case that a later load or store still references this
checkmaps instruction? In that case, wouldn't those uses then refer
directly to value? Or do you consider such a check to be an escaping
use?
https://codereview.chromium.org/21055011/diff/28001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/21055011/diff/28001/src/hydrogen.cc#newcode2964
src/hydrogen.cc:2964: if (FLAG_use_escape_analysis)
Run<HEscapeAnalysisPhase>();
I think you might want to run after the first DCE phase, so that objects
don't escape through dead code somehow.
https://codereview.chromium.org/21055011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
