Good catch! Fixed in https://codereview.chromium.org/22314010/.
Note that this code is currently never executed anyway because double constants are not emitted at uses, so as far as I can see this can't actually cause any issues. On Tue, Aug 6, 2013 at 5:08 AM, <[email protected]> wrote: > The latest version of this file on line 261 > is > ---------------- > else if (source->IsDoubleRegister()) { > DoubleRegister result = cgen_->ToDoubleRegister(destination); > -------------------- > > is this right？ > > i think is > > else if (destination->IsDoubleRegister()) { > > > ? > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > > > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
