LGTM (with a nit).
https://codereview.chromium.org/22426003/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/22426003/diff/1/src/factory.cc#newcode1159
src/factory.cc:1159: GetTypedArrayFun(type, native_context));
nit: Instead of passing "Context*" into GetTypedArrayFun() can we
instead pass in "Isolate*"? Just to prevent accidental use of the
potentially stale "native_context" variable here.
https://codereview.chromium.org/22426003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
