LGTM with comment.
The visualization tool (tools/plot-timer-event) would surely benefit from
this
additional piece of information as well. But if you don't want to deal with
that, I can do that later on.
https://codereview.chromium.org/22412003/diff/3001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/22412003/diff/3001/src/api.cc#newcode7643
src/api.cc:7643: if (is_idle) {
Could we assert that the current vm state at this point is either IDLE
or EXTERNAL?
https://codereview.chromium.org/22412003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
