LGTM iff the copy-n-paste is removed (it's the small things that make our
code
base so ugly...).
Furthermore, adding this on MIPS would be nice, too, because it is a
no-brainer
and keeps our platforms in sync.
https://codereview.chromium.org/22593003/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/22593003/diff/1/src/arm/lithium-codegen-arm.cc#newcode809
src/arm/lithium-codegen-arm.cc:809: (FLAG_trap_on_stub_deopt &&
info()->IsStub())) {
To remove the copy-n-paste, please make this a predicate on
CompilationInfo:
if (info()->ShouldTrapOnDeopt()) {
...
}
https://codereview.chromium.org/22593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
