Reviewers: alph, loislo, Benedikt Meurer, Yang,
Message:
This change should be landed after Blink r155755 is rolled into Chromium.
Description:
Deprecate self and total time getters and total sample count getter on
CpuProfileNode
All of these values are derived from the self samples count and there is no
need
to evaluate them in v8 when clients can do that when needed on their side.
BUG=267595
Please review this at https://codereview.chromium.org/22347003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8-profiler.h
M src/profile-generator.cc
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index
f2128ce0bed6bb35ebcbdca72cfd6e56d892f892..88cd0e6455ae0f1193b27c2de69fe6b22cce2f35
100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -61,16 +61,16 @@ class V8_EXPORT CpuProfileNode {
* Returns total (self + children) execution time of the function,
* in milliseconds, estimated by samples count.
*/
- double GetTotalTime() const;
+ V8_DEPRECATED(double GetTotalTime() const);
/**
* Returns self execution time of the function, in milliseconds,
* estimated by samples count.
*/
- double GetSelfTime() const;
+ V8_DEPRECATED(double GetSelfTime() const);
/** Returns the count of samples where function exists. */
- double GetTotalSamplesCount() const;
+ V8_DEPRECATED(double GetTotalSamplesCount() const);
/** Returns the count of samples where function was currently executing.
*/
double GetSelfSamplesCount() const;
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index
018973b15ec874dd572412255a9347fc4c9e6ae9..86bd17b70a08b304dd40af5424127a3659436714
100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -220,7 +220,7 @@ double ProfileNode::GetTotalMillis() const {
void ProfileNode::Print(int indent) {
- OS::Print("%5u %5u %*c %s%s #%d %d",
+ OS::Print("%5u %5u %*c %s%s %d #%d",
total_ticks_, self_ticks_,
indent, ' ',
entry_->name_prefix(),
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
