Reviewers: alph, loislo, Sven Panne,
Message:
This change depends on the following Blink CL:
https://codereview.chromium.org/22684004/
Description:
Deprecate CpuProfileNode::GetSelfSamplesCount
This method is being replaced by GetHitCount.
BUG=267595
Please review this at https://codereview.chromium.org/22295009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M include/v8-profiler.h
M test/cctest/test-cpu-profiler.cc
Index: include/v8-profiler.h
diff --git a/include/v8-profiler.h b/include/v8-profiler.h
index
e538f4a84068e6836567453eddb1b00b7d0ccbd4..936ea59ffb9d73c266ac861bb07d1f813cb5fe10
100644
--- a/include/v8-profiler.h
+++ b/include/v8-profiler.h
@@ -75,7 +75,7 @@ class V8_EXPORT CpuProfileNode {
/** DEPRECATED. Please use GetHitCount instead.
* Returns the count of samples where function was currently executing.
*/
- double GetSelfSamplesCount() const;
+ V8_DEPRECATED(double GetSelfSamplesCount() const);
/**
* Returns the count of samples where the function was currently
executing.
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc
b/test/cctest/test-cpu-profiler.cc
index
7b5fc2b0fe7f9daa418ef9cc06338284a7bc0281..ca60ee7e28e66673c014e43ddd7484f23d50f05c
100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -27,12 +27,14 @@
//
// Tests of profiles generator and utilities.
+#define V8_DISABLE_DEPRECATIONS 1
#include "v8.h"
#include "cpu-profiler-inl.h"
#include "cctest.h"
#include "platform.h"
#include "utils.h"
#include "../include/v8-profiler.h"
+#undef V8_DISABLE_DEPRECATIONS
using i::CodeEntry;
using i::CpuProfile;
using i::CpuProfiler;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
